Fix: Renaming a judging room/table preserves list order#2112
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/FIRSTIsrael/lems/sessions/cc22dcba-a7f1-4fe6-b1df-26619f5fb7b1 Co-authored-by: johnmeshulam <55348702+johnmeshulam@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug that moves judging room to the bottom after renaming
Fix: Renaming a judging room/table preserves list order
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming a judging room or robot game table in the admin venue page caused the item to jump to the bottom of the list. This happened because the rename triggered a full SWR re-fetch, and the server returns items sorted alphabetically — placing the renamed item at its new alphabetical position.
Fix: Use SWR's bound
mutateto update the renamed item in-place in the cache instead of invalidating and re-fetching:Add and delete operations continue to use a full re-fetch (correct behavior for those cases).
Type of change
Screenshots
N/A — order now stays stable after renaming a room or table.
Checklist